Skip to content

Validate host tags on VM live scale#6409

Merged
DaanHoogland merged 2 commits intoapache:mainfrom
scclouds:validate-host-tags-on-scale
Aug 31, 2022
Merged

Validate host tags on VM live scale#6409
DaanHoogland merged 2 commits intoapache:mainfrom
scclouds:validate-host-tags-on-scale

Conversation

@BryanMLima
Copy link
Copy Markdown
Contributor

@BryanMLima BryanMLima commented May 23, 2022

Description

Currently, ACS does not validate host tags on running VMs that have their computing resources increased via Scale VM command. Therefore, if a service offering with host tags deploys on a host with the same host tags, it is permitted to live scale this VM to another service offering with another host tags. This PR aims to fix this bug, verifying the host tags on a VM live scaling.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab with the following scenario:

  1. VM deployed with a service offering with host tags hdd.
  2. Tried to live scale the VM with another service offering with host tags ssd.
  3. An error occurred while scaling the VM, as expected.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

GutoVeronezi
GutoVeronezi approved these changes Jun 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@GutoVeronezi GutoVeronezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@GutoVeronezi
Copy link
Copy Markdown
Contributor

GutoVeronezi commented Jun 21, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 21, 2022

@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 21, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✖️ suse15. SL-JID 3618

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 22, 2022

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 22, 2022

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 22, 2022

Trillian test result (tid-4351)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6409-t4351-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

JoaoJandre
JoaoJandre approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

RodrigoDLopez
RodrigoDLopez approved these changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@RodrigoDLopez RodrigoDLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@BryanMLima
Copy link
Copy Markdown
Contributor Author

BryanMLima commented Aug 30, 2022

@DaanHoogland @GutoVeronezi Could you take another look on this one? I think this PR is already good to merge.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Aug 31, 2022

trusting the developers tests on this one

@DaanHoogland DaanHoogland merged commit d4b8e2c into apache:main Aug 31, 2022
@yadvr yadvr added this to the 4.18.0.0 milestone Aug 31, 2022
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 31, 2022

cc @DaanHoogland milestone missing

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 31, 2022

Also manual tests if any required missing cc @shwstppr @harikrishna-patnala

neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
@BryanMLima @neogismm
Validate host tags on VM live scale (apache#6409)
bb87f11 
* Validate host tags on VM live scale

* Remove extra spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GutoVeronezi GutoVeronezi GutoVeronezi approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

+1 more reviewer

@RodrigoDLopez RodrigoDLopez RodrigoDLopez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@BryanMLima @GutoVeronezi @blueorangutan @sureshanaparti @DaanHoogland @yadvr @RodrigoDLopez @JoaoJandre